Support KHR_technique_webgl extension in GLTF2Loader #11344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @donmccurdy |
donmccurdy
requested changes
May 16, 2017
examples/js/loaders/GLTF2Loader.js
Outdated
| @@ -1642,11 +1668,16 @@ THREE.GLTF2Loader = ( function () { | |||
|
|
|||
| materialType = DeferredShaderMaterial; | |||
|
|
|||
| var technique = json.techniques[ material.technique ]; | |||
| var extension = extensions[ EXTENSIONS.KHR_TECHNIQUE_WEBGL ]; | |||
There was a problem hiding this comment.
Similar to spec-gloss, could we do something like this to factor most of this code out of this large loadMaterials method?
materialType = DeferredShaderMaterial;
extensions[ EXTENSIONS.KHR_TECHNIQUE_WEBGL ].extendParams( materialParams, material, dependencies );There was a problem hiding this comment.
I'm thinking to do that when we remove the existing json.target code (see the Update in the PR comment)
So, adding some comments so far?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets
GLTF2Loadersupport KHR_technique_webgl extensionUpdate:
I've left the existing
json.techniquescode as is so far thoughtechniquesis moved to extension in glTF 2.0 becauseit seems there're many models which have
techniquesunder corejson.I'm gonna remove it when glTF 2.0 release is officially announced.