PolyhedronGeometry: Compute flat normals when detail is zero #11330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, i've often seen this. I think it's called an I'm fine with this change. |
Mugen87
approved these changes
May 13, 2017
Mugen87
reviewed
May 13, 2017
src/geometries/PolyhedronGeometry.js
Outdated
|
|
||
| if ( detail === 0 ) { | ||
|
|
||
| BufferGeometry.prototype.computeVertexNormals.call( this ); // flat normals |
There was a problem hiding this comment.
Just for my understanding 😇 : Why not this.computeVertexNormals()?
There was a problem hiding this comment.
Good point. Thanks.
And it appears to have flat normals -- even at higher detail. |
|
BTW, I think the UVs for |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, smooth normals were computed all the time.
However, flat normals are more appropriate when the
detailparameter is zero, resulting in a regular polyhedron.When
detailis greater than zero, the geometry is tessellated. Personally, I think flat normals are more appropriate in that case, too. However, I believe some users are usingIcosahedronGeometryas a stand-in for a sphere, and would object to the change. Consequently, this PR retains smooth normals whendetailis non-zero. I do not see the point in adding an optional flag./ping @Mugen87