misc_animation_keys example update #11304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
requested changes
May 9, 2017
examples/misc_animation_keys.html
Outdated
|
|
||
| var tracks = []; | ||
| // POSITION | ||
| var positionKF = new THREE.VectorKeyframeTrack('.position', [0, 1, 2], [0, 0, 0, 30, 0, 0, 0, 0, 0]); |
There was a problem hiding this comment.
Formatting does not seem to be consistent...
examples/misc_animation_keys.html
Outdated
| var clip = new THREE.AnimationClip( 'Action', -1, tracks ); | ||
| var qInitial = new THREE.Quaternion().setFromAxisAngle( xAxis, 0 ); | ||
| var qFinal = new THREE.Quaternion().setFromAxisAngle( xAxis, Math.PI ); | ||
| var quaternionKF = new THREE.QuaternionKeyframeTrack('.quaternion', [0, 1, 2], [qInitial.x, qInitial.y, qInitial.z, qInitial.w, qFinal.x, qFinal.y, qFinal.z, qFinal.w, qInitial.x, qInitial.y, qInitial.z, qInitial.w ]); |
There was a problem hiding this comment.
Some whitespaces are missing at various places: Instead of [0, 1, 2] -> [ 0, 1, 2 ]
There was a problem hiding this comment.
Seems like I turned on some option that does that automatically when I save the file somehow 🙁
|
@looeee 👍, but wouldn't it perhaps be nice to switch the single animations on/off via buttons? |
Would do this in a separate example. |
I would keep it simple. @looeee's implementation is fine. |
Mugen87
approved these changes
May 9, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VectorKeyframeTrackfor.positionand.scale.QuaternionKeyframeTrack, rotating about x axis ( and switched to sphere to box so that rotation is visible).It occurred to me that this example should be renamed to misc / animation / basic_use as that is what it's really showing. Then it could also be expanded a little more to show how
AnimationObjectGroupworks, and maybe a couple of other simple things.