Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glTF] Use default byteOffset=0. #11294

Merged
merged 1 commit into from
May 14, 2017
Merged

[glTF] Use default byteOffset=0. #11294

merged 1 commit into from
May 14, 2017

Conversation

donmccurdy
Copy link
Collaborator

Fixes an issue in the Corset sample model.

@donmccurdy donmccurdy changed the title [gltf] Use default byteOffset=0. [glTF] Use default byteOffset=0. May 8, 2017
@takahirox takahirox mentioned this pull request May 14, 2017
Closed
13 tasks
@takahirox
Copy link
Collaborator

Is bufferView.byteOffset an optional now?
So, this specification would be old? https://github.com/KhronosGroup/glTF/tree/2.0/specification/2.0#bufferview

@mrdoob mrdoob merged commit f0db61d into mrdoob:dev May 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 14, 2017

Thanks!

@donmccurdy
Copy link
Collaborator Author

Is bufferView.byteOffset an optional now?

I'm not sure. byteOffset is missing from some of the sample models, but that specification is the latest version and ought to be correct.. I think let's wait until the glTF2.0 specification and models are finalized and then file an issue if there is still an inconsistency, leaving the patch in for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donmccurdy @takahirox @mrdoob