Simplified RectAreaLightHelper #11223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other helpers must be added a child of the scene, and this helper was the only exception, so I made this helper compatible with the others. (Maybe someday we can change this limitation.)
I also simplified the helper to be a simple wireframe outline, rather than a plane mesh, because the helper was blocking view of the scene.
Finally, we can't set the color of the helper to be the product of the light color and light intensity as long as lights intensities are allowed to be arbitrarily greater then one. This is a change we should make to all the light helpers, in fact.