Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put section number for Section 5 "Equation 2: Multihead Self-Attention (MSA block)" #817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ideaguy3d
Copy link

When viewed from an IDE with navigation (e.g. DataSpell) it looked like

4. Equation 1: ...
Equation 2: ...
6. Equation 3: ...

so I simply added "5." to make it clearer "5. Equation 2: Multihead Self-Attention (MSA block)" is the 5th section

When viewed from an IDE with navigation (e.g. DataSpell) it looked like
```
4. Equation 1: ...
Equation 2: ...
6. Equation 3: ...
```
so I simply added "5." to make it clearer "5. Equation 2: Multihead Self-Attention (MSA block)" is the 5th section
@smith-kyle
Copy link

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/mrdbourke/pytorch-deep-learning/pull/817

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants