Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color argument when invoking hg [Was: Mercurial update breaks the plugin] #39

Closed
adab4d opened this issue Jan 12, 2018 · 4 comments
Closed

Comments

@adab4d
Copy link

adab4d commented Jan 12, 2018

On an Ubuntu 16.04 using Visual Studio Code 1.19.2 and Hg extension v1.2.2-3, updating the system's mercurial from 3.7.3 to 4.4.1 using official PPA results in an empty Source Control area in side bar.

There are no modified or untracked files, the source control is recognized as "HG".

Using mercurial in command line works without flaws.

Reverting to previous version fixes the issue.

@adab4d
Copy link
Author

adab4d commented Jan 17, 2018

This is not sistematic, sometimes I get a working vscode Source Control side bar with 4.4.

I'm not sure where I can gather relevant info from the plugin, any hint about that appreciated.

@adab4d
Copy link
Author

adab4d commented Jan 19, 2018

I stand corrected, it turned out I had already updated my global hgrc to use builtin color extension rather and the color = always is what actually messes up vscode-hg.

Turns out when reverting to 3.7.3 the ui.color setting was not effective and therefore the vscode-hg worked just fine.

The issue is then actually a feature request, please either force --color=never when calling mercurial or provide a setting to inject arguments when invoking mercurial so each user can pick his own poison.

@adab4d adab4d changed the title Mercurial update breaks the plugin Add color argument when invoking hg [Was: Mercurial update breaks the plugin] Jan 19, 2018
@adab4d
Copy link
Author

adab4d commented Feb 7, 2018

In case someone else hits the same issue, just create an hg-no-color wrapper containing:

#!/bin/sh

/usr/bin/hg --config ui.color=never "$@"

@incidentist
Copy link
Collaborator

Fixed in 1.4.0. The extension now ensures color output is disabled when running its commands.

incidentist pushed a commit to incidentist/vscode-hg that referenced this issue Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants