Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Multi-root Workspaces and Hg Support #29

Closed
seanmcbreen opened this issue Oct 18, 2017 · 5 comments
Closed

VS Code Multi-root Workspaces and Hg Support #29

seanmcbreen opened this issue Oct 18, 2017 · 5 comments
Assignees

Comments

@seanmcbreen
Copy link

Hi,

I'm from the VS Code team [we have chatted before :)] and I'm reaching out with some additional resources for adopting multi-root workspaces.

But first let me say thank you for working on and maintaining Hg/Mecurial Support for VS Code, we really appreciate the work you have done to make VS Code better.

The purpose of this issue is that we are very close to releasing a significant new feature for VS Code - Multi-root Workspaces - which is the most requested missing feature. If you have not heard of multi-root workspaces we have described this in several of our recent updates. Today it's only enabled in our insiders release but our intent is to enable it for all users in our next update, targeted for release in the first week of November.

This is a pretty significant change and over the last four months we have updated pretty much all of VS Code to be Multi-root aware as well as updated all of our own extensions. In the process of doing this we have created a set of guidelines for Extension Authors to follow to ensure their extension can fully leverage the awesomeness that is Multi-root workspaces.

Our Request:

There are a few things to review in your extension to ensure it can fully capitalize on Multi-root Workspaces....

  • Check you do not make use of the (now deprecated) workspace.rootPath property, there is a proposed migration path and sample for this case.
  • Review any settings you contribute or change, specifically you need to review whether some of the settings can be applied on a resource (= file location) level instead of being global (= workspace level).

How Can We Help/Resources:

We realize we are asking for your help here - our goal is to make sure that your extensions works well with multi-root and continues to be loved by the community. The guide above outlines the changes that are required and we have a samples as well.

But we are sure you will have questions and we thought one way we could look to help is by getting a number of the team members (myself included) to be ready to respond to questions on a Slack Channel that we will dedicate to this issue. To join that channel simply follow this link.

Again thank you for being part of the VS Code community - we appreciate everything you have done. With the release of Multi-root Workspaces we will be shipping our most requested feature, together we can really help this feature light up for users.

Happy Coding!
Sean McBreen

p.s. we are also working on some additional cool SCM features - specifically SCM Status in the Explorer and Inline SCM Actions more details on these will be included in the next release.

// cc @bpasero @joaomoreno

@mrcrowl mrcrowl self-assigned this Oct 22, 2017
@mrcrowl
Copy link
Owner

mrcrowl commented Oct 22, 2017

WIP

This was referenced Oct 22, 2017
@mrcrowl
Copy link
Owner

mrcrowl commented Oct 22, 2017

Addressed in v1.2.0. Now uploaded to marketplace.

@mrcrowl mrcrowl closed this as completed Oct 22, 2017
@seanmcbreen
Copy link
Author

Sorry for asking post the publish of v1.2.0 :s

Request: if you have prepared your extension for Multi-root Workspaces we would love you to add multi-root ready to your package.json i.e. "keywords": ["multi-root ready"]. If you upgrade to VSCE 1.32.0 this can be added to any existing keywords and will not be counted against the maximum of 5 allowed keywords.

This will help us keep track of adoptions and also help users know which extensions have been fully tested. Remember we are here to help should you need it on the Slack channel.

Happy Coding
Sean McBreen

@mrcrowl
Copy link
Owner

mrcrowl commented Nov 1, 2017 via email

@seanmcbreen
Copy link
Author

1.18 should ship mid next week with multi-root, the cool new SCM stuff and... a blue icon :)

Thank you!
Sean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants