Remove to strct condition, debug mode compiles

mratsim · Nov 21, 2019 · 9feb8d0 · 9feb8d0
1 parent c19e12e
commit 9feb8d0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/weave/channels/channels_mpsc_unbounded b/weave/channels/channels_mpsc_unbounded
diff --git a/weave/datatypes/sparsesets.nim b/weave/datatypes/sparsesets.nim
@@ -87,7 +87,9 @@ func contains*(s: SparseSet, n: SomeInteger): bool {.inline.} =
 
 func incl*(s: var SparseSet, n: SomeInteger) {.inline.} =
   preCondition: n < Empty
-  preCondition: n notin s
+
+  if n in s: return
+
   preCondition: s.len < s.capacity
 
   s.indices[n] = s.len
@@ -101,7 +103,7 @@ func peek*(s: SparseSet): int32 {.inline.} =
   int32 s.values[s.len - 1]
 
 func excl*(s: var SparseSet, n: SomeInteger) {.inline.} =
-  preCondition: n in s
+  if n notin s: return
 
   # We do constant time deletion by replacing the deleted
   # integer by the last value in the array of values

diff --git a/weave/targets.nim b/weave/targets.nim
@@ -24,11 +24,10 @@ proc markIdle(victims: var SparseSet, workerID: WorkerID) =
     # Invalid worker ID (parent of root or out-of-bound child)
     return
 
-  preCondition: workerID notin victims
-
   let maxID = workforce() - 1
   if workerID < workforce():
     # mark children
+    victims.excl(workerID)
     markIdle(victims, left(workerID, maxID))
     markIdle(victims, right(workerID, maxID))