Nvidia: deactivate Edwards25519 on Nvidia backend for now#559
Merged
Conversation
This was referenced Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #445, there are 2 representations used on CPU for field elements, either the canonical representation if a field has access to a fast reduction like for Mersenne or Pseudo-Mersenne/Crandall or Solinas primes or the Montgomery representation.
The Nvidia backend only supports Montgomery representation at the moment.
Inputs are memcpied into the GPU for computation assuming CPU and GPU representations are matching but they aren't.
Workarounding by checking if the inputs and output should be memcpied or not seems to be non-trivial work so for now we don't support Edwards25519 on Nvidia GPU while waiting got the Crandall acceleration introduced in #445, namely this file https://github.com/mratsim/constantine/blob/v0.2.0/constantine/math/arithmetic/limbs_crandall.nim to be ported to GPU.