Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nim v1.2.0 update #20

Closed
wants to merge 1 commit into from
Closed

Nim v1.2.0 update #20

wants to merge 1 commit into from

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Apr 7, 2020

No description provided.

@mratsim
Copy link
Owner Author

mratsim commented Apr 8, 2020

1.2.0 not working on Linux might be related to the corruption from nim-lang/Nim#13902 as Word is a distinct uint64

@mratsim mratsim mentioned this pull request Jun 4, 2020
Merged
@mratsim
Update CI with Nim 1.2.0
5591d17 
Fix script if somehow Nim was built but not Nimble (Travis ARM for channel Stable)

Add debug tooling for Nim stable on Azure Linux 64-bit: https://dev.azure.com/numforge/Constantine/_build/results?buildId=421&view=logs&j=772f230d-746a-56d1-bc2f-fb811c7e19c9&t=b523bb2e-7fa8-50fa-b6c6-60216421c47f
@mratsim
Copy link
Owner Author

mratsim commented Jun 18, 2020

So Nim 1.2.2 has other limiting bugs related to static:
image
/home/vsts/work/1/s/constantine/elliptic/ec_endomorphism_accel.nim(307, 9) Error: invalid type for const: staticCurve

constantine/constantine/elliptic/ec_endomorphism_accel.nim

Lines 297 to 310 in 5591d17

func scalarMulGLV*[scalBits](
P: var ECP_SWei_Proj,
scalar: BigInt[scalBits]
) =
## Elliptic Curve Scalar Multiplication
##
## P <- [k] P
##
## This is a scalar multiplication accelerated by an endomorphism
## via the GLV (Gallant-lambert-Vanstone) decomposition.
const C = P.F.C # curve
static: doAssert: scalBits == C.getCurveOrderBitwidth()
when P.F is Fp:
const M = 2

Nim 1.2.x is probably not meant to be. Closing the PR.

@mratsim mratsim closed this Jun 18, 2020
@mratsim mratsim mentioned this pull request Jun 18, 2020
Closed
mratsim added a commit that referenced this pull request Jun 18, 2020
@mratsim
Don"t include Nim 1.2.x #20 (comment)
6b22a07
mratsim added a commit that referenced this pull request Jun 19, 2020
@mratsim
Don"t include Nim 1.2.x #20 (comment)
5369eda
mratsim added a commit that referenced this pull request Jun 19, 2020
@mratsim
Github Action CI (without GMP) (#29)
a2a2495 
* Github Action CI (without GMP)

* Deactivate MacOS, spurious failures: actions/runner-images#841

* force install with nimble

* Add badge

* Don"t include Nim 1.2.x #20 (comment)

* Action branch mistake

* Add back OSX? actions/runner-images#841, actions/runner-images#969

* fix MacOS target

* comment out RDTSC on i386

* Add initialization canaries

* Add more verbose output to debug windows failures

* spurious windows i386 test

* For now only activate Linux and mac

* missed include
@mratsim mratsim deleted the Nim-v1.2.0 branch February 13, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mratsim