Skip to content

Fix N1QL creator to support @Field annotation on derived method queries.#1

Open
mmonti wants to merge 2 commits intomraible:mainfrom
mmonti:fix-sd-n1ql-creator
Open

Fix N1QL creator to support @Field annotation on derived method queries.#1
mmonti wants to merge 2 commits intomraible:mainfrom
mmonti:fix-sd-n1ql-creator

Conversation

@mmonti
Copy link
Copy Markdown

@mmonti mmonti commented Feb 1, 2021

This PR contains changes needed to have all the integration tests fixed. Some of these changes can be included in JHipster Generator and others are required in Spring Data Couchbase project and are described here:

@mikereiche
Copy link
Copy Markdown

@mraible
Copy link
Copy Markdown
Owner

mraible commented Feb 3, 2021

@mmonti What do you think the best way forward is? Should I integrate your changes in JHipster's main generator or should we wait for Spring Data Couchbase fixes? We could do another JHipster 7 beta without it since it's not working currently.

@mmonti
Copy link
Copy Markdown
Author

mmonti commented Feb 3, 2021

I think we can do another JHipster 7 beta for now so at least we can have a version working. I will make another commit in this PR to leave only the files needed and you can integrate (we don't need the changes in QueryCriteria since I replaced "findAllByIdNotNullAndActivatedIsTrue" query with a @query). I can also do it if needed.

I think that I misread the ticket that @mikereiche shared about DATACOUCH-1055 and thought that change was merged, but seems that the ticket was just closed.

I did some tests with 4.2.0-SNAPSHOT and the classes I added to fix the current issues will not work (some of the classes I extended are deprecated in 4.2.x), so we will need to do another update when we decide to move from 4.1.3 to 4.2.x

@mraible
Copy link
Copy Markdown
Owner

mraible commented Feb 3, 2021

@mmonti OK. I'll integrate your changes into the main generator this evening.

coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants