Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.lua: increase default font and border size #14088

Closed
wants to merge 1 commit into from

Conversation

guidocella
Copy link
Contributor

I don't know how people can use it but console.lua with the default font and border size is unreadable to me. It looks ridiculous next to the default huge --osd-font-size. Increment them to make the console more readable, especially since it can now be used a seletcor.

I don't know how people can use it but console.lua with the default font
and border size is unreadable to me. It looks ridiculous next to the
default huge --osd-font-size. Increment them to make the console more
readable, especially since it can now be used a seletcor.
Copy link

github-actions bot commented May 8, 2024

Download the artifacts for this pull request:

Windows
macOS

@na-na-hi
Copy link
Contributor

na-na-hi commented May 8, 2024

How about making the console scale with video size by default? It's the case for all other UI elements, and it avoids artifacts while resizing the window due to the way OSD is drawn.

@guidocella
Copy link
Contributor Author

Personally I use --osd-scale-by-window=no --sub-scale-by-window=no to have consistent text sizes like in any other application. But if we do implement scaling I think it would be more convenient to make scripts respect --osd-scale-by-window instead of making users configure vidscale in each script, similar to what I did in 51bd00c.

Regardless we still need to set default font and border sizes, it may be just me finding it small and hard to read over videos as e.g. christoph-henrich said he's using font_size=13 while I use 40 lol, so I will close this if the consensus is that the default sizes are fine.

@na-na-hi
Copy link
Contributor

na-na-hi commented May 8, 2024

Personally I use --osd-scale-by-window=no --sub-scale-by-window=no to have consistent text sizes like in any other application.

Doesn't this PR kind of defeat this purpose? The current default is close to the normal text size of other programs. Increasing it to 26 makes it significantly larger, and I found it too large that lots of autocomplete items can't be shown if I don't maximize the mpv window, and it would also be a problem with low resolution displays like 1366x768.

@guidocella
Copy link
Contributor Author

By consistent I was referring to the text size not changing after resizing. 16 seems generally smaller than average to me but I guess it's fine as is.

@guidocella guidocella closed this May 8, 2024
@guidocella guidocella deleted the console-size branch May 8, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants