-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripting: add mp.input.select() #13982
Conversation
5b87b2d
to
35e25a3
Compare
I personally expect 500+ lines of vendored 3rd-party dependency to do more than just this one thing. For example, |
I'm not sure fuzzy matching would help for |
If the performance is fine then I think it's better than the C version for this purpose. It's in a managed language and a lot less code to deal with. |
35e25a3
to
dde2c43
Compare
Download the artifacts for this pull request: |
ecc1cfe
to
47a40fa
Compare
This allows scripts to make the user choose from a list of entries by typing part of their text and/or by navigating them with keybindings, like dmenu or fzf. Closes mpv-player#13964.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works. Not much to say, nice addition.
This allows scripts to make the user choose from a list of entries by typing part of their text and/or by navigating them with keybindings, like dmenu or fzf.
Closes #13964.
This is simple by reusing console.lua's code and even works in the terminal. I'm not sure if we should go with this or implement a more graphical menu. Example usage: