osxbundle: avoid running codesign with deprecated --deep argument#13379
osxbundle: avoid running codesign with deprecated --deep argument#13379Akemi merged 1 commit intompv-player:masterfrom
codesign with deprecated --deep argument#13379Conversation
|
sry for the late reply, i wanted to get some vulkan/moltenvk bundling changes into mpv before this. anyway with 6b5b4b7 we are now bundling vulkan loaders (driver + layers) with the App bundle. because of that we have another folder where dylibs reside a bit sad about the |
`--deep` is deprecated as of macos 13.0. It is also not supported by alternative `codesign` implementations like [sigtool](https://github.com/thefloweringash/sigtool). Related: NixOS/nixpkgs#270691
|
@Akemi Thanks, I've updated the function to contain a list of directories with binaries to sign. I've also verified that it still works with |
|
Download the artifacts for this pull request: |
|
thanks for your fix and contribution. |
--deepis deprecated as of macos 13.0.It is also not supported by alternative
codesignimplementations likesigtool.
Related: NixOS/nixpkgs#270691
Read this before you submit this pull request:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md
Reading this link and following the rules will get your pull request reviewed
and merged faster. Nobody wants lazy pull requests.