Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the track selection in the OSC hidden sometimes #10621

Closed
ColonelGerdauf opened this issue Sep 7, 2022 · 1 comment · Fixed by #15031
Closed

Have the track selection in the OSC hidden sometimes #10621

ColonelGerdauf opened this issue Sep 7, 2022 · 1 comment · Fixed by #15031
Labels
meta:feature-request

Comments

@ColonelGerdauf
Copy link

ColonelGerdauf commented Sep 7, 2022 •
edited
Loading

Expected behavior of the wanted feature

What I am hoping for is for MPV to have a mechanism that can prohibit the user from selecting the audio track of "none" in the OSC, specifically when audio is playing.

That is an example use case where "none" will cause more problems than it is worth. When you hit "none" on the OSC when music is playing, the music stops in its tracks, and any other audio that you play via MPV will get instantly skipped. Especially when the appropriate settings are not in place, this will lead to an immediate shutdown of MPV as a program immediately after it launches. This will be a major nuisance, especially for those that choose to use MPV or one of the many front-end packages as a mainstay music player.

Alternative behavior of the wanted feature

Alternatively, though less ideal, an option can be provided to users to selectively hide or show the track button in the default OSC, on a general basis.
@Traneptora
Copy link
Member

Does this solve the issue? https://github.com/viniciusbm/mpv-cycle-through-existing/blob/master/cycle-through-existing.lua

guidocella added a commit to guidocella/mpv that referenced this issue Oct 22, 2024
@guidocella
osc.lua: open select.lua by clicking buttons
f91fbc3 
8bf5548 added mouse support to the console's select menu, so open it
from OSC buttons.

Right click is used for playlist and chapter menus instead of middle
click because it is easier to press on laptops and the interactive and
scrollable menus are more useful than show-text.

Left click on the title opens the playlist selector and "show playlist
position and length and full title" is moved to right click, because
left clicking the title is not as useful as left clicking to go to
adjacent playlist entries or chapters.

Left click opens the track selectors because seeing which track you're
selecting beforehand is moer useful than with playlist and chapter
navigation.

Fixes mpv-player#10621.
@guidocella guidocella mentioned this issue Oct 22, 2024
Merged
guidocella added a commit to guidocella/mpv that referenced this issue Oct 22, 2024
@guidocella
osc.lua: open select.lua by clicking buttons
8ef4395 
8bf5548 added mouse support to the console's select menu, so open it
from OSC buttons.

Left click on the title opens the playlist selector and showing the
playlist is moved to right click.

Right click on playlist-prev and playlist-next also opens the playlist
selectors, they could alternatively show the playlist.

Right click on chapter buttons open the chapter selector.

Left click on track buttons opens the track selectors because seeing
which track you're selecting beforehand is useful.

Fixes mpv-player#10621.
guidocella added a commit to guidocella/mpv that referenced this issue Oct 22, 2024
@guidocella
osc.lua: open select.lua by clicking buttons
a924d45 
8bf5548 added mouse support to the console's select menu, so open it
from OSC buttons.

Left click on the title opens the playlist selector and showing the
stats is moved to right click.

Right click on chapter buttons opens the chapter selector.

Left click on track buttons opens the track selectors because seeing
which track you're selecting beforehand is useful.

Fixes mpv-player#10621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

osc.lua: open select.lua by clicking buttons guidocella/mpv
2 participants
@Traneptora @ColonelGerdauf