Skip to content

Conversation

@ngabor84
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #409 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #409      +/-   ##
============================================
+ Coverage     91.32%   91.36%   +0.03%     
- Complexity      204      205       +1     
============================================
  Files            10       10              
  Lines           519      521       +2     
============================================
+ Hits            474      476       +2     
  Misses           45       45
Impacted Files Coverage Δ Complexity Δ
src/Tools/RouteMatcher.php 97.43% <100%> (+0.13%) 17 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5267dc...89ec6b2. Read the comment docs.

@shalvah
Copy link
Contributor

shalvah commented Nov 22, 2018

This is great work! I think we should add it for includes too, for consistency's sake. Also, please update the documentation.

@ngabor84
Copy link
Contributor Author

Thanks! I updated the readme and the config template, and I also add this functionality to includes.

@shalvah
Copy link
Contributor

shalvah commented Nov 23, 2018

Thanks for this excellent PR.

@shalvah shalvah merged commit 1b82a8d into mpociot:master Nov 23, 2018
@shalvah shalvah changed the title handle patterns in exclude list handle patterns in include and exclude list Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants