Skip to content

Conversation

@alinzh
Copy link
Contributor

@alinzh alinzh commented Dec 14, 2024

  • change Pandas on Polars package
  • update existing tests, add tests for export MPDS

@pep8speaks
Copy link

pep8speaks commented Dec 14, 2024

Hello @alinzh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 9:80: E501 line too long (88 > 79 characters)

Line 37:80: E501 line too long (84 > 79 characters)
Line 128:80: E501 line too long (84 > 79 characters)
Line 134:80: E501 line too long (88 > 79 characters)
Line 151:80: E501 line too long (80 > 79 characters)
Line 153:80: E501 line too long (80 > 79 characters)
Line 165:80: E501 line too long (80 > 79 characters)

Line 39:80: E501 line too long (81 > 79 characters)
Line 103:80: E501 line too long (86 > 79 characters)
Line 109:80: E501 line too long (87 > 79 characters)
Line 221:80: E501 line too long (88 > 79 characters)
Line 222:80: E501 line too long (83 > 79 characters)
Line 292:80: E501 line too long (81 > 79 characters)
Line 415:80: E501 line too long (80 > 79 characters)

Line 11:80: E501 line too long (84 > 79 characters)
Line 16:80: E501 line too long (80 > 79 characters)
Line 23:80: E501 line too long (84 > 79 characters)
Line 28:80: E501 line too long (81 > 79 characters)
Line 46:80: E501 line too long (81 > 79 characters)

Line 18:80: E501 line too long (108 > 79 characters)
Line 61:80: E501 line too long (81 > 79 characters)
Line 86:80: E501 line too long (86 > 79 characters)
Line 112:80: E501 line too long (85 > 79 characters)
Line 118:80: E501 line too long (86 > 79 characters)
Line 129:80: E501 line too long (85 > 79 characters)
Line 141:80: E501 line too long (85 > 79 characters)
Line 159:80: E501 line too long (85 > 79 characters)
Line 170:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-12-19 18:01:22 UTC

@alinzh
Copy link
Contributor Author

alinzh commented Dec 14, 2024

This test is no longer relevant, because an error occurred in an unusual range of received data.

Also in the export_MPDS.py I replaced pickle with parquet, since polars does not support pickle

@alinzh
Copy link
Contributor Author

alinzh commented Dec 17, 2024

Perhaps it is worth adding path for saving as an optional argument?
https://github.com/mpds-io/mpds-client/blob/master/mpds_client/export_MPDS.py#L43

@alinzh
Copy link
Contributor Author

alinzh commented Aug 17, 2025

@blokhin, can we merge?

@blokhin
Copy link
Member

blokhin commented Aug 20, 2025

@alinzh please, make sure first all the seven examples from here work.

@alinzh
Copy link
Contributor Author

alinzh commented Aug 27, 2025

@blokhin, these examples were adapted by me for polars in this PR mpds-io/mpds-api#63 . All 7 examples were launched today, works correctly.

@blokhin blokhin merged commit 3ea9646 into mpds-io:master Sep 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants