Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classifiers #87

Merged
merged 3 commits into from
May 4, 2018
Merged

Update classifiers #87

merged 3 commits into from
May 4, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 2, 2018

Support for EOL Python 2.6 and 3.3 were removed in ccaff6c#diff-354f30a63fb0907d4ad57269548329e3 and 1c7691b#diff-354f30a63fb0907d4ad57269548329e3.

Update the classifiers to match.

This also modernises some code which is possible in 2.7/3.4+.

@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files          13       13           
  Lines        1004     1004           
=======================================
  Hits          940      940           
  Misses         64       64
Impacted Files Coverage Δ
jose/jwk.py 95.12% <100%> (ø) ⬆️
jose/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d568676...6d458ef. Read the comment docs.

@hugovk
Copy link
Contributor Author

hugovk commented May 2, 2018

And here's the pip installs for python-jose from PyPI for last month:

python_version percent download_count
2.7 90.46% 195,778
3.6 5.68% 12,298
3.5 2.27% 4,904
3.4 1.57% 3,402
3.7 0.01% 19
2.6 0.01% 18

Source: pypinfo --start-date -31 --end-date -2 --percent --pip --markdown python-jose pyversion

@zejn
Copy link
Collaborator

zejn commented May 3, 2018

Looks good to me.

@mpdavis
Copy link
Owner

mpdavis commented May 4, 2018

lgtm

@mpdavis mpdavis merged commit 99de7b1 into mpdavis:master May 4, 2018
@hugovk hugovk deleted the rm-eol branch May 4, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants