Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denylist ecdsa 0.15 in setup.py to allow for 0.16 to be installed. #199

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

dreid
Copy link
Contributor

@dreid dreid commented Nov 30, 2020

The previous pull request #192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.

The previous pull request mpdavis#192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.
@blag
Copy link
Contributor

blag commented Dec 7, 2020

I should have had PR #192 tweak the parameters we pass to the ecdsa backend, as explained here. But since I didn't, do you mind fixing that in this PR? That is why so many of the tests are failing.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #199 (d59ad6d) into master (a2a4c31) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          16       16           
  Lines        1728     1728           
=======================================
  Hits         1616     1616           
  Misses        112      112           
Impacted Files Coverage Δ
jose/backends/ecdsa_backend.py 98.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a4c31...d59ad6d. Read the comment docs.

@blag blag merged commit 8572088 into mpdavis:master Dec 8, 2020
@blag
Copy link
Contributor

blag commented Dec 8, 2020

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants