Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just emit a warning when verifying with a private key #168

Merged
merged 8 commits into from
Dec 20, 2019

Conversation

blag
Copy link
Contributor

@blag blag commented Dec 19, 2019

Closes #53.
Closes #142.

Emits warning when user attempts to verify message with a private key.

Gasper Zejn and others added 3 commits April 28, 2019 22:01
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   96.57%   97.18%   +0.61%     
==========================================
  Files          14       14              
  Lines        1079     1067      -12     
==========================================
- Hits         1042     1037       -5     
+ Misses         37       30       -7
Impacted Files Coverage Δ
jose/exceptions.py 100% <ø> (ø) ⬆️
jose/jws.py 96.72% <ø> (ø) ⬆️
jose/utils.py 100% <ø> (+12.28%) ⬆️
jose/backends/cryptography_backend.py 98.11% <100%> (ø) ⬆️
jose/backends/rsa_backend.py 96.57% <100%> (+0.02%) ⬆️
jose/backends/pycrypto_backend.py 95.86% <100%> (+0.03%) ⬆️
jose/jwk.py 95.06% <100%> (-0.07%) ⬇️
jose/backends/ecdsa_backend.py 98.66% <100%> (ø) ⬆️
jose/__init__.py 100% <100%> (ø) ⬆️
jose/jwt.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40920a5...6a3865b. Read the comment docs.

@blag blag force-pushed the rsa-privkey-no-verify branch from 24c7714 to e4b92e0 Compare December 19, 2019 10:28
@blag blag changed the title Rsa privkey no verify Just emit a warning when verifying with a private key Dec 20, 2019
@blag blag force-pushed the rsa-privkey-no-verify branch from 5eae276 to a560fdb Compare December 20, 2019 08:38
@blag blag force-pushed the rsa-privkey-no-verify branch from a560fdb to c25d615 Compare December 20, 2019 09:12
@blag blag force-pushed the rsa-privkey-no-verify branch from c25d615 to 2d7f481 Compare December 20, 2019 09:23
@blag blag force-pushed the rsa-privkey-no-verify branch from 2d7f481 to 58fc6b3 Compare December 20, 2019 09:27
@blag blag force-pushed the rsa-privkey-no-verify branch from 58fc6b3 to 6a3865b Compare December 20, 2019 10:18
@blag blag merged commit b4d4385 into mpdavis:master Dec 20, 2019
@blag blag deleted the rsa-privkey-no-verify branch December 20, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWS verification succeeds with both public and private keys when signing with the private key using RS256
1 participant