Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json encodeable jwk dict #165

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Conversation

blag
Copy link
Contributor

@blag blag commented Dec 17, 2019

Closes #127.
Closes #137.
Closes #139.

@blag blag added the bug label Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          14       14           
  Lines        1062     1062           
=======================================
  Hits         1032     1032           
  Misses         30       30
Impacted Files Coverage Δ
jose/backends/ecdsa_backend.py 98.66% <ø> (ø) ⬆️
jose/backends/cryptography_backend.py 98.11% <ø> (ø) ⬆️
jose/backends/rsa_backend.py 96.5% <ø> (ø) ⬆️
jose/backends/pycrypto_backend.py 95.76% <ø> (ø) ⬆️
jose/jwk.py 95.06% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba738d9...9df2861. Read the comment docs.

@blag blag merged commit 1390392 into mpdavis:master Dec 19, 2019
@blag blag deleted the json-encodeable-jwk-dict branch December 19, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwk construct with hs256 returns 'k' as binary JWK can not be dumped to JSON
1 participant