Remove constant_time_string_compare #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blag
force-pushed
the
remove-constant-time-string-compare
branch
from
08fd8a4 to
d7ca2bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 96.46% 97.08% +0.62%
==========================================
Files 14 14
Lines 1076 1065 -11
==========================================
- Hits 1038 1034 -4
+ Misses 38 31 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hmac.compare_digestfunction was added in Python 2.7, which is the minimum that we support. We no longer need this compatibility shim.