Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE-2017-11424 Applies to python-jose as well! #62

Closed
sirosen opened this issue Sep 1, 2017 · 0 comments
Closed

CVE-2017-11424 Applies to python-jose as well! #62

sirosen opened this issue Sep 1, 2017 · 0 comments

Comments

@sirosen
Copy link
Contributor

sirosen commented Sep 1, 2017

CVE-2017-11424 details a key confusion attack against pyjwt.

As I understand it, we just need to add another magic string to this check

Not being a crypto expert, I'll open a pull request with the fix described in the CVE, but would appreciate someone else taking a look at the CVE before merging.
sirosen added a commit to sirosen/python-jose that referenced this issue Sep 1, 2017
@sirosen
Fix for CVE-2017-11424
8a1e536 
Add "RSA PUBLIC KEY" to the forbidden key strings in HMAC. Prevents the
use of PKCS1 keys, cited by this CVE as exposing a key-confusion attack.
Also add a test case for it, doing the obvious thing.

Closes mpdavis#62
@sirosen sirosen mentioned this issue Sep 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sirosen