Add people properties

Author: alexs-mparticle

MixpanelEventForwarder.js

@@ -125,7 +125,11 @@
             attr[key] = value;
 
             try {
-                mixpanel.mparticle.register(attr);
+                if (forwarderSettings.useMixpanelPeople) {
+                    mixpanel.mparticle.people.set(attr);
+                } else {
+                    mixpanel.mparticle.register(attr);
+                }
             }
             catch(e) {
                 return 'Can\'t call register on forwarder: ' + name + ': ' + e;
@@ -134,7 +138,11 @@
 
         function removeUserAttribute(attribute) {
             try {
-                mixpanel.mparticle.unregister(attribute);
+                if (forwarderSettings.useMixpanelPeople) {
+                    mixpanel.mparticle.people.unset(attribute);
+                } else {
+                    mixpanel.mparticle.unregister(attribute);
+                }
             }
             catch(e) {
                 return 'Can\'t call unregister on forwarder: ' + name + ': ' + e;

package.json

@@ -3,8 +3,7 @@
   "description": "mParticle integration sdk for Mixpanel",
   "repository": "https://github.com/mParticle/integration-mixpanel",
   "devDependencies": {
-    "blanket": "1.1.7",
-    "should": "7.1.0",
-    "mocha": "2.3.2"
+    "should": "13.2.3",
+    "mocha": "^5.2.0"
   }
 }

test/index.html

@@ -9,7 +9,6 @@
 
     <script src="../node_modules/mocha/mocha.js"></script>
     <script src="../node_modules/should/should.js"></script>
-    <script src="../node_modules/blanket/dist/mocha/blanket_mocha.js"></script>
     <script src="mockhttprequest.js"></script>
     <script>
         var mp = function () {

test/tests.js

@@ -108,6 +108,14 @@ describe('Mixpanel Forwarder', function () {
             setCalledAttributes(data, 'unregisterCalled');
         };
 
+        this.mparticle.people.set = function (data) {
+            setCalledAttributes(data, 'setCalled');
+        };
+
+        this.mparticle.people.unset = function (data) {
+            setCalledAttributes(data, 'unsetCalled');
+        };
+
         this.mparticle.people.track_charge = function (data) {
             setCalledAttributes(data, 'trackChargeCalled');
         };
@@ -151,7 +159,7 @@ describe('Mixpanel Forwarder', function () {
             window.mixpanel.mparticle.data[1].should.be.instanceof(Object);
 
             window.mixpanel.mparticle.data[0].should.be.equal('Test Page Event');
-            Should(window.mixpanel.mparticle.data[1]).eql({});
+            window.mixpanel.mparticle.data[1].should.be.an.Object().and.be.empty();
 
             done();
         });
@@ -169,7 +177,7 @@ describe('Mixpanel Forwarder', function () {
             window.mixpanel.mparticle.data[1].should.be.instanceof(Object);
 
             window.mixpanel.mparticle.data[0].should.be.equal('Viewed Test Page Event');
-            Should(window.mixpanel.mparticle.data[1]).eql({});
+            window.mixpanel.mparticle.data[1].should.be.an.Object().and.be.empty();
 
             done();
         });
@@ -211,6 +219,32 @@ describe('Mixpanel Forwarder', function () {
 
     });
 
+    describe('People Properties', function () {
+        it('should set a user property', function(done) {
+            mParticle.forwarder.init({
+                useMixpanelPeople    : 'True'
+            }, reportService.cb, true);
+
+            mParticle.forwarder.setUserAttribute('email', '[email protected]');
+            window.mixpanel.mparticle.should.have.property('setCalled', true);
+            window.mixpanel.mparticle.data.should.be.an.instanceof(Object).and.have.property('email', '[email protected]');
+
+            done();
+        });
+
+        it('should unset a user property', function(done) {
+            mParticle.forwarder.init({
+                useMixpanelPeople    : 'True'
+            }, reportService.cb, true)
+
+            mParticle.forwarder.removeUserAttribute('email', '[email protected]');
+            window.mixpanel.mparticle.should.have.property('unsetCalled', true);
+            window.mixpanel.mparticle.data.should.be.an.instanceof(Object).and.not.have.property('email', '[email protected]');
+
+            done();
+        });
+    });
+
     describe('Transaction events', function() {
         it('should track charge event', function(done) {
             mParticle.forwarder.init({