Skip to content

Commit 67461f9

Browse files
authored
Bugfix - update pageView naming
1 parent 4085dab commit 67461f9

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

MixpanelEventForwarder.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,12 @@
6666
}
6767

6868
try {
69-
if (event.EventDataType == MessageType.PageEvent ||
70-
event.EventDataType == MessageType.PageView) {
71-
69+
if (event.EventDataType == MessageType.PageEvent) {
70+
reportEvent = true;
71+
logEvent(event);
72+
}
73+
else if (event.EventDataType == MessageType.PageView) {
74+
event.EventName = 'Viewed ' + event.EventName;
7275
reportEvent = true;
7376
logEvent(event);
7477
}

test/tests.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,24 @@ describe('Mixpanel Forwarder', function () {
156156
done();
157157
});
158158

159+
it('should log a page view with \'Viewed\' prepended to the event name', function(done) {
160+
mParticle.forwarder.process({
161+
EventDataType : MessageType.PageView,
162+
EventName : 'Test Page Event'
163+
});
164+
165+
window.mixpanel.mparticle.should.have.property('trackCalled', true);
166+
window.mixpanel.mparticle.data.should.be.instanceof(Array).and.have.lengthOf(2);
167+
168+
window.mixpanel.mparticle.data[0].should.be.type('string');
169+
window.mixpanel.mparticle.data[1].should.be.instanceof(Object);
170+
171+
window.mixpanel.mparticle.data[0].should.be.equal('Viewed Test Page Event');
172+
Should(window.mixpanel.mparticle.data[1]).eql({});
173+
174+
done();
175+
});
176+
159177
});
160178

161179
describe('User events', function() {

0 commit comments

Comments
 (0)