Skip to content

Conversation

@jshin-tse
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • change override function supportsAttributeLists to return true

Testing Plan

  • No, flag was previously set to true and was changed mistakenly to false

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@samdozor samdozor requested a review from jasonmgeorge October 6, 2023 16:24
@markvdouw markvdouw merged commit ff1c5ad into development Oct 16, 2023
@markvdouw markvdouw deleted the fix/supportsAttributeLists branch October 16, 2023 21:17
markvdouw pushed a commit that referenced this pull request Dec 21, 2023
* fix: Manually adding custom attributes for NON PURCHASE EVENTS (#147)

* Manually adding custom attributes for NON PURCHASE EVENTS

* Adding commented test

* fix: Forward Custom Attributes for all Commerce Events (#150)

* feat: SQDSDKS-5551 Changing test for sideloading kits feature (#151)

Fixing test to accomodate new architecture change for sideloaded kits

* chore: bump android-sdk-ui from 24.3.0 to 25.0.0 (#133)

:arrow_up: Upgrade Braze Android SDK from v24 to v25

* fix: flip supportsAttributeLists back to true (#162)

Signed-off-by: jshin-tse <[email protected]>

* Bumping min version to API 21 based on Braze documentation
Bumping to latest Braze version

---------

Signed-off-by: jshin-tse <[email protected]>
Signed-off-by: markvdouw <[email protected]>
Co-authored-by: Brandon Stalnaker <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: jshin-tse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants