Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android 11 freezing issues #289

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

BrendonSled
Copy link
Contributor

Following this thread twilio/twilio-video-app-react#355

Calling the stream.removeTrack before .stop() fixes the freezing issues in Android 11.

Following this thread twilio/twilio-video-app-react#355

Calling the `stream.removeTrack` before `.stop()` fixes the freezing issues in Android 11.
@BrendonSled
Copy link
Contributor Author

This fixes #284

@mozmorris
Copy link
Owner

@BrendonSled apologies I missed this. Will sort out getting this merged and maybe do a pre-release so we can get some feedback.

@mozmorris
Copy link
Owner

mozmorris commented May 25, 2021

@BrendonSled I have published this under the next tag (or 5.2.4-0). Would you mind testing it for me? I have tried on a few devices here and all looks okay, but always nice to get another pair of eyes.

There's a CodePen using the next tag here: https://codepen.io/mozmorris/pen/vYxZgrP

@BrendonSled
Copy link
Contributor Author

looks good to me, we're currently using this in a forked state on our production app

@mozmorris mozmorris merged commit 130bf94 into mozmorris:master May 25, 2021
@mozmorris
Copy link
Owner

Thank you very much @BrendonSled 👍

@mozmorris
Copy link
Owner

Released in 5.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants