-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial code #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
force-pushed
the
initial-banner
branch
29 times, most recently
from
February 7, 2024 10:30
015af2b
to
cf55768
Compare
alexgibson
force-pushed
the
initial-banner
branch
from
February 12, 2024 10:20
cf55768
to
48c6289
Compare
alexgibson
force-pushed
the
initial-banner
branch
8 times, most recently
from
February 29, 2024 13:58
3422c92
to
9adf5e0
Compare
alexgibson
force-pushed
the
initial-banner
branch
9 times, most recently
from
March 7, 2024 13:34
0feb48a
to
0e51ea4
Compare
alexgibson
force-pushed
the
initial-banner
branch
from
March 7, 2024 14:09
0e51ea4
to
8e9873f
Compare
stephaniehobson
requested changes
Mar 14, 2024
🦆 🦆 🦆 Ducks are all in a row. Just one blocking issue and a bunch of other thoughts that you are under no obligation to do if you are sick of looking at this code ;) |
@stephaniehobson many thanks for the review - I pushed a commit with some fixes 👍 |
@stephaniehobson could you take a look and approve this PR if the updates look OK? Thank you |
R+ 🦆 |
stephaniehobson
approved these changes
Mar 19, 2024
Leaving it for you to handle the squash and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Start with
README.md
and take things from there.npm start
?npm run build
work OK?npm test
?