Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial code #1

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add initial code #1

merged 2 commits into from
Mar 20, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 31, 2024

Description

  • Adds banner JS logic / tests.
  • Adds banner SCSS/CSS.
  • Adds webpack for building NPM package and local dev environment.
  • Updates documentation.

Testing

Start with README.md and take things from there.

  • Does everything install OK?
  • Do the docs make sense?
  • Does the demo / local dev page work correctly running npm start?
  • Does building the package using npm run build work OK?
  • Do the tests pass as expected running npm test?

@alexgibson alexgibson force-pushed the initial-banner branch 8 times, most recently from 3422c92 to 9adf5e0 Compare February 29, 2024 13:58
@alexgibson alexgibson marked this pull request as ready for review February 29, 2024 14:00
@alexgibson alexgibson force-pushed the initial-banner branch 9 times, most recently from 0feb48a to 0e51ea4 Compare March 7, 2024 13:34
tests/index.js Show resolved Hide resolved
tests/index.js Outdated Show resolved Hide resolved
tests/index.js Show resolved Hide resolved
tests/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/styles.scss Outdated Show resolved Hide resolved
src/styles.scss Show resolved Hide resolved
@stephaniehobson
Copy link
Collaborator

🦆 🦆 🦆 Ducks are all in a row. Just one blocking issue and a bunch of other thoughts that you are under no obligation to do if you are sick of looking at this code ;)

@alexgibson
Copy link
Member Author

@stephaniehobson many thanks for the review - I pushed a commit with some fixes 👍

@alexgibson
Copy link
Member Author

@stephaniehobson could you take a look and approve this PR if the updates look OK? Thank you

@stephaniehobson
Copy link
Collaborator

R+ 🦆

@stephaniehobson
Copy link
Collaborator

Leaving it for you to handle the squash and merge.

@alexgibson alexgibson merged commit 984a296 into main Mar 20, 2024
1 check passed
@alexgibson alexgibson deleted the initial-banner branch March 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants