Add rate limiting #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejalim
force-pushed
the
85-rate-limiting
branch
3 times, most recently
from
9a74d2d
to
98baa26
Compare
stevejalim
commented
Sep 27, 2023
| @@ -19,6 +19,16 @@ jobs: | |||
| run: | | |||
| pip install -r requirements/production.txt | |||
| pip install -r requirements/test.txt | |||
| - name: Set up Node | |||
There was a problem hiding this comment.
I'll be replacing this setup with running tests inside the Docker container soon
stevejalim
force-pushed
the
85-rate-limiting
branch
from
98baa26
to
518aeac
Compare
This changeset adds rate limiting to the project in a way that is compatible with Wagtail. Because the core CMS-based page-serving happens via a single view, we cannot just use the decorators from django_ratelimit as we do elsewhere in the org. Instead we have custom middleware that uses the core helpers from the django-ratelimit package to do the work. This changeset also adds a 403 template as well as a 429 one for ratelimited responses.
stevejalim
force-pushed
the
85-rate-limiting
branch
from
518aeac
to
e17a360
Compare
pmac
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds rate limiting to the project in a way that is compatible with Wagtail.
Because the core CMS-based page-serving happens via a single view, we cannot just use the decorators from
django-ratelimitas we do elsewhere in the org. Instead we have custom middleware that uses the core helpers from thedjango-ratelimitpackage to do the work.This changeset also adds a 403 template as well as a 429 one for ratelimited responses.
Resolves #85