Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决#326:使 PyInstaller 在 Windows 下无需手动加 --collect-data pypinyin 就可打包程序 #329

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

xushengj
Copy link
Contributor

@xushengj xushengj commented Sep 9, 2024

按照 pyinstaller/hooksample 样例 添加 pypinyin/__pyinstaller目录,当程序使用了 pypinyin 且在Windows下用 PyInstaller 打包时,其中的 hook 会自动加 collect_data_files

@xushengj
Copy link
Contributor Author

xushengj commented Sep 9, 2024

完全不知道这些冒出来的 CircleCI 的测试错误怎么解决。。能麻烦看一下吗。。

@mozillazg
Copy link
Owner

@xushengj 谢谢你的贡献,我晚点看一下。可以忽略 CircleCI 相关的错,我这边会处理。

Copy link
Owner

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mozillazg mozillazg merged commit ae570e6 into mozillazg:develop Sep 9, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants