Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Decode: don't fill value for struct fields that don't exist in header #5

Merged
merged 1 commit into from
Apr 9, 2022
Merged

fix Decode: don't fill value for struct fields that don't exist in header #5

merged 1 commit into from
Apr 9, 2022

Conversation

mozillazg
Copy link
Owner

Fixes #4

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2084458031

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.0%) to 93.134%
Files with Coverage Reduction New Missed Lines %
decode.go 1 94.26%
Totals Coverage Status
Change from base Build 1540259834: 3.0%
Covered Lines: 312
Relevant Lines: 335
💛 - Coveralls

@mozillazg mozillazg mentioned this pull request Apr 3, 2022
Closed
@mozillazg mozillazg merged commit 052df69 into master Apr 9, 2022
@mozillazg mozillazg deleted the decode-check-header-present branch April 9, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fillValues case reflect.Int, reflect.Int64 provides error if header is not set
2 participants
@mozillazg @coveralls