Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove obsolete deprecation warning logged on sendResponse callback calls #406

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

rpl
Copy link
Member

@rpl rpl commented Aug 9, 2022

fixes #386

@rpl rpl requested a review from Rob--W August 9, 2022 20:32
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #406 (0f156c8) into master (032bc57) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   91.03%   90.71%   -0.33%     
==========================================
  Files           1        1              
  Lines         145      140       -5     
==========================================
- Hits          132      127       -5     
  Misses         13       13              
Impacted Files Coverage Δ
src/browser-polyfill.js 90.71% <ø> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rpl
Copy link
Member Author

rpl commented Aug 9, 2022

@Rob--W I wouldn't worry about covecov complaining about the reduced coverage, that warning wasn't explicitly covered but I guess that from codecov prespective there are just less lines of code and the same number of misses and that ends up triggering its codecov/project check failure.

@rpl rpl merged commit f6b12b7 into master Aug 12, 2022
@rpl rpl deleted the fix/remove-obsolete-sendResponse-deprecation-warning branch August 12, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the warning logged when sendResponse callback is being called
2 participants