Record metadata for a struct implementing a trait. #2204
+335
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-yolpttzuvznp
branch
3 times, most recently
from
5411e96
to
fa42fd1
Compare
|
Bindings all turned out to be fairly easy - which in some ways is "bad" because it highlights an inefficiency here, but good because it seems fine and useful. |
mhammond
force-pushed
the
push-yolpttzuvznp
branch
from
fa42fd1
to
d177e59
Compare
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
force-pushed
the
push-yolpttzuvznp
branch
from
d177e59
to
7163779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently works by ignoring
MyTrait. This adds new metadatato record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes #2196.