Fix restarting downloads #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
commented
Jul 31, 2024
| @@ -299,10 +299,15 @@ def download_chunks(self) -> Generator[bytes, None, None]: | |||
| # the retries are done. | |||
| logger.error(f"A download error occurred: {error}") | |||
|
|
|||
There was a problem hiding this comment.
This is the codepath that runs when a response times out, or a network connection is lost.
There was a problem hiding this comment.
I'm not sure if "with" can be applied here to ensure the resources will be closed in any case
There was a problem hiding this comment.
I have been playing around with @contextmanager(I think you pointed that out) and ExitStack. This could would probably be simpler with that.
eu9ene
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download restarts weren't working because the
chunk_iterhere was being closed, when only the response needed to be closed between restarts. I tested this manually locally.