-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude start stage tasks from existing tasks #713
base: release
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a generally good thing, or could there be groups in previous_group_ids
where we'd want to overwrite one task from it but not another? The safer way to do this may be to allow a list of labels, substrings or prefixes to be specified in the training config, and filter anything matching them out of existing_tasks
.
(We do something similar for optimizations. We can't directly use that here, but we could use the same technique to keep things flexible.
@bhearsum It probably depends on the situation but usually, I want to restart all the tasks with |
I think it's probably fine on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the release branch. Can you rewrite the merge commit to have a message like "RELEASE ONLY: Exclude start stage tasks from existing tasks"
so that we don't accidentally cherry pick it back?
I think I'm doing fine with just cherry-picking this into a separate branch so we don't have to merge it at all if you have doubts it's the right solution here |
This fixes the edge case where we have alignments-original -> alignments-backtranslated both marked as
stage: alignments-teacher
and want to restart both of them. We should probably split them later to two stages but not now because it breaks the ability to reuse previous graphs.