Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the existing_tasks explicitly provided in the action's input #683

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

gabrielBusta
Copy link
Member

This is a way to explicitly replace a task in a group with another task of the same kind from another group.

Copy link
Collaborator

@eu9ene eu9ene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielBusta gabrielBusta marked this pull request as ready for review June 18, 2024 19:49
@gabrielBusta gabrielBusta requested a review from a team as a code owner June 18, 2024 19:49
@gabrielBusta gabrielBusta requested a review from jcristau June 18, 2024 19:49
Copy link
Collaborator

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is ideal, but I'm fine with it, and don't have any better ideas at the moment.

Please update this to explicitly log the labels and task ids of any existing_tasks that end up overridden to aid future debugability.

@gabrielBusta gabrielBusta requested a review from bhearsum June 18, 2024 21:11
@gabrielBusta
Copy link
Member Author

Done @bhearsum :)

@eu9ene eu9ene merged commit a0edcdc into release Jun 19, 2024
9 checks passed
gregtatum pushed a commit to gregtatum/translations that referenced this pull request Jun 25, 2024
…mozilla#683)

* Override the existing_tasks explicitly provided in the action's input

* Log the labels and task ids of any existing tasks that are overridden

---------

Co-authored-by: Evgeny Pavlov <[email protected]>
gregtatum pushed a commit that referenced this pull request Jun 25, 2024
…#683)

* Override the existing_tasks explicitly provided in the action's input

* Log the labels and task ids of any existing tasks that are overridden

---------

Co-authored-by: Evgeny Pavlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants