Index maps support #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Three main consumer objects now, SourceMapConsumer, SimpleSourceMapConsumer, and IndexSourceMapConsumer. - SourceMapConsumer & SimpleSourceMapConsumer are basically identical, feeling like they should be merged & the canonical SourceMapConsumer should stay the same. - Started adding section support to basic SourceMapConsumer - Wrote async fetching util function & started tests for it but then commented them out - Abstracted out safe JSON parsing fn into a util for better sharing
- Basically anything not shared goes into either Index/SimpleSMC - SSMC passing basic instantiation test, basically nothing else.
This will need to be reverted once I have new SourceMapConsumer properly returning an instance of SimpleSourceMapConsumer or IndexSourceMapConsumer. Not there yet though.
Removing errant ISMC test stub.
|
Haven't had time to dig in yet, but I have a quick note: in the tests, you shouldn't need to change the import to |
Just a temp thing while I move pieces around a bit & figure out how to hang it all together. Wanted to be sure I hadn't broken everything ever with my renaming. It'll go back to the way it was before I declare this "done" 🐼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: TOTALLY INCOMPLETE SO FAR!
This will hopefully fix #16, some day. Issuing PR to get conversation started & make sure I'm not going totally off the rails.
Started building out
Simple&IndexSourceMapConsumersthat inherit from a baseSourceMapConsumerthat defines shared behavior. Not much progress yet althrough I do have aSimpleSourceMapConsumerpassing the basic "this thing can be instantiated test".