Remove the bundled dist/ directory? #362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in favor of removing the
dist/
folder at this point because it's not clear who the target users are, and bundling is much more common now that it was whendist
was created in 2015.source-map
alreadylet
andconst
mappings.wasm
's location for browsersThose are all a complex enough that I find it hard to see the average user dropping
source-map
into their application without their own bundler. Having the extra files also increasesnpm
package size with minimal benefit, and complicates maintenance if we ever want to add other dependencies since they'd all need to be bundled intodist
too.If we get requests for this after it is removed, I'm 100% for exploring options, but since
npm
is the primary distribution mechanism right now, it seems like most users will not be using from the registry anyway. Given that, we could also instead include standalone bundles attached to the Github releases or some other channel.