Update shlex dependency to version 2 - #2836
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
- Coverage 73.82% 70.18% -3.64%
==========================================
Files 72 72
Lines 38087 38054 -33
==========================================
- Hits 28117 26709 -1408
- Misses 9970 11345 +1375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/comex/rust-shlex/blob/653936e120cdd0a8d1b4f0837e2cce0f347da4c0/CHANGELOG.md. There is only one file with calls into
shlex, and it doesn’t use any of the APIs that were removed in v2:sccache/src/compiler/nvcc.rs
Line 113 in c710468
sccache/src/compiler/nvcc.rs
Line 127 in c710468
sccache/src/compiler/nvcc.rs
Line 1125 in c710468
This has the pleasant side effect of deduplicating
shlexinCargo.lock, sinceccalready updated its dependency to v2.