Skip to content

Update shlex dependency to version 2 - #2836

Merged
sylvestre merged 1 commit into
mozilla:mainfrom
musicinmybrain:shlex2
Aug 31, 2026
Merged

sylvestre merged 1 commit into
mozilla:mainfrom
musicinmybrain:shlex2

Conversation

@musicinmybrain

@musicinmybrain musicinmybrain commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

See https://github.com/comex/rust-shlex/blob/653936e120cdd0a8d1b4f0837e2cce0f347da4c0/CHANGELOG.md. There is only one file with calls into shlex, and it doesn’t use any of the APIs that were removed in v2:

arguments = shlex::split(flags)

shlex::split(flags)

let args = match shlex::split(&line) {

This has the pleasant side effect of deduplicating shlex in Cargo.lock, since cc already updated its dependency to v2.

@codecov-commenter

codecov-commenter commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.18%. Comparing base (c710468) to head (9ba2d59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   73.82%   70.18%   -3.64%     
==========================================
  Files          72       72              
  Lines       38087    38054      -33     
==========================================
- Hits        28117    26709    -1408     
- Misses       9970    11345    +1375     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
sylvestre merged commit 036fc5c into mozilla:main Aug 31, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants