Skip to content

Conversation

@rtyler
Copy link
Contributor

@rtyler rtyler commented Aug 23, 2025

Without this change, users may be greeted with the following confusing
message when trying to build on Linux/arm64

error[E0601]: `main` function not found in crate `sccache_dist`
   --> /home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sccache-0.10.0/src/bin/sccache-dist/main.rs:835:2
    |
835 | }
    |  ^ consider adding a `main` function to `/home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sccache-0.10.0/src/bin/sccache-dist/main.rs`

For more information about this error, try `rustc --explain E0601`.

With this change:

error: Distributed compilation is only support on Linux/x86_64 and FreeBSD!
  --> src/bin/sccache-dist/main.rs:43:5
   |
43 |     compile_error!("Distributed compilation is only support on Linux/x86_64 and FreeBSD!");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Without this change, users may be greeted with the following confusing
message when trying to build on Linux/arm64

```
error[E0601]: `main` function not found in crate `sccache_dist`
   --> /home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sccache-0.10.0/src/bin/sccache-dist/main.rs:835:2
    |
835 | }
    |  ^ consider adding a `main` function to `/home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sccache-0.10.0/src/bin/sccache-dist/main.rs`

For more information about this error, try `rustc --explain E0601`.
```

With this change:

```
error: Distributed compilation is only support on Linux/x86_64 and FreeBSD!
  --> src/bin/sccache-dist/main.rs:43:5
   |
43 |     compile_error!("Distributed compilation is only support on Linux/x86_64 and FreeBSD!");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@rtyler rtyler marked this pull request as ready for review August 23, 2025 18:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.94%. Comparing base (36c8b89) to head (b4c7e06).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2435      +/-   ##
==========================================
+ Coverage   67.31%   70.94%   +3.63%     
==========================================
  Files          64       65       +1     
  Lines       35165    35523     +358     
==========================================
+ Hits        23670    25203    +1533     
+ Misses      11495    10320    -1175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre merged commit 86abf90 into mozilla:main Aug 23, 2025
48 of 57 checks passed
@sylvestre
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants