Skip to content

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Mar 7, 2025

The nvcc -time and nvcc -fdevice-time-trace flags generate a csv/flamegraph to aid in debugging compilation times.

This PR ensures they're parsed as TooHard, yielding a CompileResult::CannotCache, and falling back to invoking nvcc directly.

@trxcllnt trxcllnt force-pushed the fix/nvcc-device-time-trace branch from 1b7a9af to 072d426 Compare March 7, 2025 19:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (0cc0c62) to head (072d426).
Report is 159 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/nvcc.rs 80.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2355       +/-   ##
===========================================
+ Coverage   30.91%   67.43%   +36.51%     
===========================================
  Files          53       65       +12     
  Lines       20112    35439    +15327     
  Branches     9755        0     -9755     
===========================================
+ Hits         6217    23897    +17680     
- Misses       7922    11542     +3620     
+ Partials     5973        0     -5973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre merged commit 42ce2f1 into mozilla:main Mar 7, 2025
60 checks passed
@trxcllnt trxcllnt deleted the fix/nvcc-device-time-trace branch March 7, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants