Skip to content

Conversation

@samuel-jimenez
Copy link
Contributor

Strip CARGO_MAKEFLAGS environment variable. Under a distributed environment, the file descriptors referenced by the client are not present on a build server.

Resolves #2333.

@sylvestre
Copy link
Collaborator

would it be possible to add a test to make sure we don't regress? thanks

@sylvestre sylvestre merged commit 2c68de8 into mozilla:main Feb 27, 2025
59 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cc0c62) to head (0198acd).
Report is 151 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2336       +/-   ##
==========================================
- Coverage   30.91%       0   -30.92%     
==========================================
  Files          53       0       -53     
  Lines       20112       0    -20112     
  Branches     9755       0     -9755     
==========================================
- Hits         6217       0     -6217     
+ Misses       7922       0     -7922     
+ Partials     5973       0     -5973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel-jimenez samuel-jimenez deleted the work/cargo_makeflags branch February 27, 2025 14:02
@mozilla mozilla deleted a comment from sylvestre Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distributed Rust compilation fails

4 participants