Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86_64-unknown-linux-gnu target #1330

Closed
wants to merge 1 commit into from

Conversation

SergioGasquez
Copy link

No description provided.

@drahnr
Copy link
Collaborator

drahnr commented Sep 22, 2022

Could you describe the benefit? Adding another target has tendency to increase the frequency of random build failures/timeouts and we already have musl that is much more limited in scope from the ABI perspective and being statically linked when it comes to artifacts

@SergioGasquez
Copy link
Author

Hi! The main benefit would be the option to download and install it using cargo binstall and, also, with the artifact approach you can install it even without having rust/cargo installed.

@drahnr
Copy link
Collaborator

drahnr commented Sep 23, 2022

So cargo-binstall tries to install based on the local target?
When it comes to artifacts, you can always download the statically linked musl on gnu linux too, so I don't see an issue here?
Given that, it seems like a limitation of cargo-binstall to not be able to detect that statically linked musl binaries are fine for gnu linux too, unless I am missing something?

@SergioGasquez
Copy link
Author

Hi! I just found cargo-bins/cargo-binstall#357, which was basically was I was running into. I am happy to close this issue as the proper solution would be to fix it in cargo-binstall

@drahnr
Copy link
Collaborator

drahnr commented Sep 23, 2022

Thank you! Glad there is a solution already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants