Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make built-in function source spec compliant. #1840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aardvark179
Copy link
Contributor

This addresses some of the issues in #1300 by removing the override of decompile on IdFunctionObject so all built in functions print as

function name() {
    [native code]
}

and updating all the doc tests to match this behaviour.

@rbri
Copy link
Collaborator

rbri commented Feb 21, 2025

Please run gradlew spotlessAppy to reformat your code..

@aardvark179 aardvark179 force-pushed the aardvark179-built-in-function-source branch from c0356f8 to e08f7e0 Compare February 24, 2025 18:28
@aardvark179
Copy link
Contributor Author

Please run gradlew spotlessAppy to reformat your code..

Sorry about that, it didn't raise the warning locally, but it does it I change the Java version. Hopefully this now passes on all supported versions.

@rbri
Copy link
Collaborator

rbri commented Feb 24, 2025

@aardvark179 thanks, looks good now. And no worries, this spotless thing is a source of fun for all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants