Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return longest text after failing to detect text longer than the configured value #423

Merged
merged 9 commits into from
Feb 27, 2018
2 changes: 1 addition & 1 deletion Readability.js
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ Readability.prototype = {
});

// But first check if we actually have something
if (this._attempts[0].textLength === 0) {
if (this._attempts[0].textLength) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed out the !, which unfortunately is quite important...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would just fix this myself and land manually, but I'm afraid my github fu is really weak and I'm in the middle of something else right now)

return null;
}

Expand Down