-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return longest text after failing to detect text longer than the configured value #423
Merged
gijsk
merged 9 commits into
mozilla:master
from
andreskrey:issue-381-try-to-return-text-after-all-attempts-failed
Feb 27, 2018
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
59d1b13
Merge pull request #1 from mozilla/master
andreskrey 42ba0b2
Merge pull request #2 from mozilla/master
andreskrey db15e5a
Merge pull request #3 from mozilla/master
andreskrey c15c0f0
Save extracted text across attempts and return the longest one when a…
andreskrey 6d55448
Fix incorrect object access
andreskrey 23f2f2c
Add hukumusume test case
andreskrey 73a293d
Fix test hukumusume test case
andreskrey 3d4d02d
Apply @gijsk feedback
andreskrey b5c6a84
Apply @gijsk feedback
andreskrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed out the
!
, which unfortunately is quite important...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I would just fix this myself and land manually, but I'm afraid my github fu is really weak and I'm in the middle of something else right now)