Ensure that failing to open the password dialog once won't permanently disable it (PR 15335 follow-up) #16768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y disable it (PR 15335 follow-up) *Please note:* This situation should never happen in practice, but it nonetheless cannot hurt to fix this. If the `PasswordPrompt.open` method would ever be called synchronously back-to-back *and* if opening of the dialog fails the first time, then the second invocation would remain pending indefinitely since we just clear out the capability.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5342612bc1e6be5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5342612bc1e6be5/output.txt Total script time: 1.42 mins Published |
…rivate as intended
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/17d52efaad46704/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/56f97dfd5f843cc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/17d52efaad46704/output.txt Total script time: 2.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/56f97dfd5f843cc/output.txt Total script time: 11.93 mins
|
timvandermeij
approved these changes
Jul 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This situation should never happen in practice, but it nonetheless cannot hurt to fix this.
If the
PasswordPrompt.openmethod would ever be called synchronously back-to-back and if opening of the dialog fails the first time, then the second invocation would remain pending indefinitely since we just clear out the capability.