Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add some resizers all around an editor (bug 1843302) #16732

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[Editor] Add some resizers all around an editor (bug 1843302) #16732

merged 1 commit into from
Jul 25, 2023

Conversation

calixteman
Copy link
Contributor

  • it'll improve the way to resize images: diagonally (in keeping ratio between dimensions) or horizontally/vertically.
  • the resizer was almost invisible in HCM.
  • make a resize undoable/redoable.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8385f94cb225cf8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8385f94cb225cf8/output.txt

Total script time: 1.61 mins

Published

@calixteman calixteman force-pushed the editor_resize branch 3 times, most recently from 4cb4857 to 899b4c3 Compare July 24, 2023 11:35
Snuffleupagus
Snuffleupagus reviewed Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also effectively "fix" https://bugzilla.mozilla.org/show_bug.cgi?id=1776906 by making it obsolete?

src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

Does this also effectively "fix" https://bugzilla.mozilla.org/show_bug.cgi?id=1776906 by making it obsolete?

Yes and we should move this bug somewhere else.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1f2a79a97a29d12/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1f2a79a97a29d12/output.txt

Total script time: 1.44 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly unfortunate that "shortcomings" in the web-platform forces us to implement this, however it does seem to work well in my testing :-)

r=me, thank you!

web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
@calixteman
[Editor] Add some resizers all around an editor (bug 1843302)
2688bf2 
- it'll improve the way to resize images: diagonally (in keeping ratio between dimensions)
  or horizontally/vertically.
- the resizer was almost invisible in HCM.
- make a resize undoable/redoable.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7bf3746f2813c19/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd438dca87c2eb4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7bf3746f2813c19/output.txt

Total script time: 4.09 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/dd438dca87c2eb4/output.txt

Total script time: 18.58 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit e006299 into mozilla:master Jul 25, 2023
@calixteman calixteman deleted the editor_resize branch July 25, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus