Remove the vinyl-fs dependency
#16730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Gulp 4, which we use for years now, the `gulp.src()` function supports the `removeBOM` option to disable the default BOM stripping, so this commit uses that to get rid of our `vinyl-fs` dependency. Note that this actually makes disabling BOM stripping work again. It's currently broken because in `vinyl-fs` 3, that we already use since 2018 in commit 95de23e, the `stripBOM` option was renamed to `removeBOM`, so the current code doesn't actually disable BOM stripping which we now confirmed and sadly broke for years without anyone noticing. Most likely this is because the BOM is not required for UTF-8 documents, but while not necessary it also can't hurt to have it for tools that use it to determine if a document is UTF-8.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/734a03981920fcf/output.txt |
Snuffleupagus
approved these changes
Jul 23, 2023
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/734a03981920fcf/output.txt Total script time: 1.41 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gulp 4, which we use for years now, the
gulp.src()function supports theremoveBOMoption to disable the default BOM stripping, so this commit uses that to get rid of ourvinyl-fsdependency.Note that this actually makes disabling BOM stripping work again. It's currently broken because in
vinyl-fs3, that we already use since 2018 in commit 95de23e, thestripBOMoption was renamed toremoveBOM, so the current code doesn't actually disable BOM stripping which we now confirmed and sadly broke for years without anyone noticing. Most likely this is because the BOM is not required for UTF-8 documents, but while not necessary it also can't hurt to have it for tools that use it to determine if a document is UTF-8.Fixes #16694.