Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't uselessly change the filter when drawing (bug 1508765) #16722

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

calixteman
Copy link
Contributor

When profiling the pdf in https://bugzilla.mozilla.org/show_bug.cgi?id=1508765, I noticed that half a second was spent to set the filter to "none".

@Snuffleupagus
Copy link
Collaborator

Should we perhaps do the same thing in e.g. the following code as well?

ctx.filter = "none";

When profiling the pdf in https://bugzilla.mozilla.org/show_bug.cgi?id=1508765,
I noticed that half a second was spent to set the filter to "none".
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/439d2d9829418d0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9639e17945ad0d3/output.txt

@marco-c marco-c changed the title Don't uselessly change the filter when drawing Don't uselessly change the filter when drawing (bug 1508765) Jul 21, 2023
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/439d2d9829418d0/output.txt

Total script time: 25.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/439d2d9829418d0/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/9639e17945ad0d3/output.txt

Total script time: 38.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 33

Image differences available at: http://54.193.163.58:8877/9639e17945ad0d3/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit d74b68c into mozilla:master Jul 21, 2023
@calixteman calixteman deleted the dont_set_filter branch July 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants